Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(bigquery): fix BQ materialized view column comments #3193

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix(bigquery): fix BQ materialized view column comments #3193

merged 2 commits into from
Sep 27, 2024

Conversation

treysp
Copy link
Contributor

@treysp treysp commented Sep 27, 2024

Fixes #3166

@treysp treysp force-pushed the trey/fix-bq-mat-view-comments branch from 5d53999 to 30f05eb Compare September 27, 2024 16:02
@treysp treysp marked this pull request as ready for review September 27, 2024 16:02
@treysp treysp enabled auto-merge (squash) September 27, 2024 16:05
@izeigerman
Copy link
Member

Test?

@treysp
Copy link
Contributor Author

treysp commented Sep 27, 2024

My bad - unit test in original PR didn't cover the full surface area

@treysp treysp force-pushed the trey/fix-bq-mat-view-comments branch from 28fb64c to e969b05 Compare September 27, 2024 16:22
@treysp treysp enabled auto-merge (squash) September 27, 2024 16:28
@treysp treysp merged commit 0758f37 into main Sep 27, 2024
23 checks passed
@treysp treysp deleted the trey/fix-bq-mat-view-comments branch September 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izeigerman izeigerman izeigerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treysp @izeigerman