Fix(clickhouse): use DateTime64(6) type in incremental time filter #3268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickhouse background
Clickhouse has two datetime types:
DateTime
: fixed one second precisionDateTime64
: user-specified precision (default of 3/millisecond when bare type passed)Clickhouse errors if you try to cast a string containing fractional seconds to
DateTime
.Current PR
SQLMesh time intervals are sometimes calculated as [datetime - 1 microsecond], returning values containing fractional seconds.
This PR prevents fractional second casting errors by always using
DateTime64
in incremental time filters. It uses a default precision of 6 unless the user explicitly passedDateTime64
.The returned type is non-nullable by default. In SCD models, however, we generate statements like
CAST(NULL AS DateTime64)
that require a nullable type. Therefore, we force nullable types when callingto_time_column()
in the SCD adapter method.