feat: add temp_schema option for table_diff #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kayrnt
force-pushed
the
table_diff_dataset
branch
2 times, most recently
from
b48d5d2
to
87001ce
Compare
Kayrnt
commented
Nov 1, 2024
| @@ -34,7 +35,7 @@ def get_table_diff( | |||
| show=False, | |||
| ) | |||
| _schema_diff = diff.schema_diff() | |||
| _row_diff = diff.row_diff() | |||
| _row_diff = diff.row_diff(temp_schema=temp_schema) | |||
There was a problem hiding this comment.
I'm not sure I'm not breaking something here, I guess it's fine.
Kayrnt
force-pushed
the
table_diff_dataset
branch
from
87001ce
to
deb9b98
Compare
georgesittas
approved these changes
Nov 2, 2024
|
I forgot to delete a small part I added in the doc (following a Copilot suggestion 🙈). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, table_diff will create a temp table in
sqlmesh_tempschema.However in some environments, the user might want to use an existing schema for that because he either don't want to create and manage another schema or he doesn't have the rights to do so.
The PR introduces a CLI parameter
--temp-schema <catalog>.<schema>or--temp-schema <schema>to write the temp tables inside that catalog and/or schema.To do list: