Fix: Add adapters for commands that are not using the snapshot evaluator #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No existing tests picked up this regression, are you able to add a test? |
Yes because these commands wouldnt work only for models which had the gateway specified property. I will think of tests to add as well |
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
5c501f2 to
01969a8
Compare
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
d02ffcf to
a31a67d
Compare
georgesittas
approved these changes
Dec 20, 2024
izeigerman
approved these changes
Dec 20, 2024
themisvaltinos
force-pushed
the
themis/engine_adapters_fix
branch
from
95a012c to
07d048c
Compare
izeigerman
reviewed
Dec 23, 2024
| @@ -1731,6 +1733,8 @@ def _normalize_snowflake(name: str, prefix_regex: str = "(sqlmesh__)(.*)"): | |||
| if config.model_defaults.dialect != ctx.dialect: | |||
| config.model_defaults = config.model_defaults.copy(update={"dialect": ctx.dialect}) | |||
|
|
|||
| # To enable parallelism in integration tests | |||
There was a problem hiding this comment.
Why does this impact parallelism?
izeigerman
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an omission on the latest multi-engine feature, to create the engine adapters in cases when they're not generated in the snapshot_evaluator property, ie for the commands
render,table_diffandcreate_test