-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test support for date/datetime/time fields #563
Conversation
1 similar comment
Apparently GPKG support for datetime is in GDAL 2.x only. Need to update test further. |
This is an absolute rabbit hole! There are more exceptions than rules, with different behaviour between GDAL 1/2 and different formats. I think we should be raising warnings for some of these differences (silent type conversions, dropping times from dates, etc). I think the test needs reformatting also as with all the exceptions it's spaghetti. I'll keep working on this. |
1301f4a
to
8128275
Compare
797e5e7
to
d2ea74b
Compare
@snorfalorpagus sorry for the review backlog! I'll try to get to them tomorrow. I see that we have an unresolved dependency on Windows. |
No problem! I created #593 for the dependency issue. The approach I've taken here is to raise a |
Wow, I'm baffled by the failure on Appveyor. The click-plugins project hasn't changed in a long time and we used to pass the tests with pip 10.0.1. I'm stumped for now. |
#540 got me looking at the support for date/datetime/time fields. It's a little complicated, with different drivers having different levels of support and behaviours. I've added some tests to illustrate the current behaviour. I don't think anything needs to change, except that we should raise a more useful error when trying to create a time-type field in an ESRI Shapefile, which currently raises an unexpected KeyError.