Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pnpm v10 #577

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Support pnpm v10 #577

merged 1 commit into from
Jan 14, 2025

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Jan 14, 2025

Closes #576

@jayvdb jayvdb marked this pull request as ready for review January 14, 2025 01:52
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0b2528a) to head (07bd0c8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #577   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines          581       581           
  Branches       101       101           
=========================================
  Hits           581       581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobysmith568
Copy link
Member

Hey @jayvdb,

Thanks for raising this.
Would you mind also dropping version 8 and adding version 10 of pnpm in the e2e test setup here?

https://github.com/TobyAndToby/generate-license-file/blob/main/.github%2Fworkflows%2Fsrc-ci.yml#L182

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 14, 2025

@tobysmith568 thanks for pointing that out.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 14, 2025

green is good ..

@tobysmith568 tobysmith568 merged commit c85a2ff into TobyAndToby:main Jan 14, 2025
20 checks passed
@jayvdb jayvdb deleted the pnpm-10 branch January 14, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pnpm v10
2 participants