New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#427 Fix error on index page when setting max expiry setting too high #429

Merged

TobySuch merged 2 commits into main from 427-overflow-max-expiry

Dec 24, 2024

Owner

TobySuch commented Dec 24, 2024

Fix error case when setting max expiry too high.

This consisted of two parts

Value being too big to convert to C int - I have put a hard limit on max expiry hours to prevent this
Value being too big to convert to datetime. Python has a max datetime of 9999-12-31 23:59:59.999999. If the code detects that the max expiry date is larger than this, we now just skip the max expiry checks as it would be too far in the future to matter.

Thanks to @helpimnotdrowning for finding the bug!

TobySuch added 2 commits

December 23, 2024 23:16


          Add max values to site settings

cf5bd3b


          Fix issue where max expiry would create too large date object

e67a03d

TobySuch merged commit 2fcc4c5 into main

4 checks passed

TobySuch deleted the 427-overflow-max-expiry branch

December 24, 2024 00:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet