Skip to content

Create /note command #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zabuzard opened this issue Jan 19, 2022 · 10 comments · Fixed by #384
Closed

Create /note command #349

Zabuzard opened this issue Jan 19, 2022 · 10 comments · Fixed by #384
Assignees
Labels
new command Add a new command or group of commands to the bot priority: normal

Comments

@Zabuzard
Copy link
Member

Zabuzard commented Jan 19, 2022

Overview

The /note command would pretty much be a 1:1 copy of /warn, but without the "DM the user"-bit.

So UX-wise, we are talking about a command like /note user:@John reason:Kinda toxic sometimes.

Hence, it should also result in an entry in the DB and being shown in the /audit command.

Technically, this is a no-brainer. However, since its basically a 1:1 copy of WarnCommand, there is potential to do some refactoring and get rid of code duplication. Might be kinda tricky in practice though, maybe not worth it.

Motivation

Sometimes mods handle a semi-critical situation informally in chat and dont want to issue a full warning that also notifies the user formally again via DM.

It is still useful to be able to just write down the incident to not forget about it in the future when judging about future situations - a note command could be useful for this.

@Zabuzard Zabuzard added new command Add a new command or group of commands to the bot priority: normal labels Jan 19, 2022
@Zabuzard Zabuzard added this to the Improvement phase 1 milestone Jan 19, 2022
@Zabuzard
Copy link
Member Author

(@marko-radosavljevic for visibility)

@Budbomber
Copy link
Contributor

Regarding this couldn't we just extend the warn command with an option - no notice or something which will not dm the user but still adds?

@Zabuzard
Copy link
Member Author

Regarding this couldn't we just extend the warn command with an option - no notice or something which will not dm the user but still adds?

In theory yes but I think that would miss the point and rather confuse. I think it is better if it is separated everywhere, as separate command to the user and in particular also in the /audit UI.
We should design such things with the user in mind, from their perspective - not from the perspective of what would be the easiest solution to code (not assuming that was your intention).

@Budbomber
Copy link
Contributor

I dont know why it closed.. But yeah makes sense, wasn't intention to make it simple more thought of it as an extension

@Budbomber Budbomber reopened this Jan 20, 2022
@marko-radosavljevic
Copy link
Contributor

marko-radosavljevic commented Feb 8, 2022

Yup, really useful feature for moderation. There are few more use cases scenarios I can think of.

One of them is documenting something about a member/situation, without them knowing about it. Those can be a bit lengthy sometimes, I imagine: links to the specific message that is being noted and commented on, time stamps, people involved, moderators that handled the action, link to the action that was taken by a moderator, reason and the backstory, thoughts on future plans about the member/situation, links to the mods discussions about it..

What I'm trying to demonstrate is, it's probably quite uncomfortable to write a well-structured and informative note in a tiny text-area, in the even tinier 'reason' slash command option, without even being able to add new lines to it. Just something to think about when implementing this, but I understand that we currently have limitations that we can't bypass easily.

@niklaswimmer
Copy link

I think we should brainstorm on what additional options might be beneficial for the note command (and probably the warn command as well).

I could imagine that an option to add a link to a Discord message would be used quite often for example (though I do not moderate so I might be wrong), extracting this information as an option would allow to display it separately in the audit log, therefor making it more structured.

An idea I have for assisting with writing a longer note would be to allow the command being send as an reply to a message. The message replied to would be taken as the notes. I am not sure if this is possible though nor about the resulting UX.

Also something to think about: do we want multiple (immutable) notes or just one "big" note per user which can be edited and expanded at any time. I feel like multiple notes would be better but I wanted to share this thought nevertheless.

@Tais993
Copy link
Member

Tais993 commented Feb 9, 2022

I think we should separate this from the warn command.

If we make the note command only ask for the user (and maybe more info)

We can use modals (forms) that accept multi-line input for the full note. This allows multi-sentence notes and has easy UX.
Only issue would be that it means this'll be blocked till #364 and #368 are merged.

@niklaswimmer
Copy link

Forms would indeed be very nice. I was not aware that Discord supports such fancy features

I think we should separate this from the warn command.

I am not so sure about this though, the idea was to have it be basically the same but without the "messages user" bit, so maybe we want to have them both work the same way - both as a form? I guess it depends on whether or not the moderators want to have greater editing capabilities for warn as well.

@Zabuzard
Copy link
Member Author

Zabuzard commented Feb 9, 2022

I dont think we have to block on forms for now. Lets do it like existing commands (warn, ban, ...), so basically suffer from the multiline issue for today - but thats okay.

And then add forms later to all those commands, not just note, once they arrive.

@Zabuzard Zabuzard self-assigned this Feb 16, 2022
@Zabuzard
Copy link
Member Author

Decided that it might be worth to offer this command also to Staff Assistants :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Add a new command or group of commands to the bot priority: normal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants