Skip to content

Update JDA to v5 (currently v4) #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
Tais993 opened this issue Feb 5, 2022 · 2 comments
Closed
3 tasks

Update JDA to v5 (currently v4) #364

Tais993 opened this issue Feb 5, 2022 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request priority: normal

Comments

@Tais993
Copy link
Member

Tais993 commented Feb 5, 2022

The issue is simple, Discord has been adding a ton of things.
Including, but not limiting to

  • autocomplete
  • context commands
  • threads
  • attachment option to slash-commands

A full list of things in WIP, or already added can be found on the Discord-developers GitHub
Since we make usage of JDA as our API wrapper, keeping this up-to-date is vital when you want to use new features. JDA is working on JDA v5, which will contain some of the new features Discord has been adding.

What we have to do

Pré v5 PR

  • Replace GuildMessageReceivedEvent with MessageReceivedEvent

v5 PR

The last point is important to keep our code maintainable in the future.
It's only talking about JDA changes, not Discord changed.
Updating commands to use the new Discord features might happen too along the way, but I don't want to combine that with this issue. If a command has to be updated, this can be done in a seperate command-specific issue.

@Tais993 Tais993 added enhancement New feature or request priority: normal dependencies Pull requests that update a dependency file labels Feb 5, 2022
@Tais993 Tais993 added this to the Improvement phase 1 milestone Feb 5, 2022
@Tais993 Tais993 self-assigned this Feb 5, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Mar 19, 2022
@Tais993 Tais993 removed the stale label Mar 19, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

@github-actions github-actions bot added stale inactivity-closed Issues that have been closed due to inactivity, but are otherwise valid and might be reopened later labels Apr 19, 2022
@marko-radosavljevic marko-radosavljevic removed inactivity-closed Issues that have been closed due to inactivity, but are otherwise valid and might be reopened later stale labels Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request priority: normal
Projects
None yet
Development

No branches or pull requests

2 participants