Skip to content

Update VC activities command with new activities #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tais993 opened this issue Feb 11, 2022 · 7 comments · Fixed by #473
Closed

Update VC activities command with new activities #378

Tais993 opened this issue Feb 11, 2022 · 7 comments · Fixed by #473
Assignees
@Korwai
Labels
enhancement New feature or request good first issue Good for newcomers priority: low

Comments

@Tais993
Copy link
Member

Tais993 commented Feb 11, 2022

Is your feature request related to a problem? Please describe.
New activities have been added, we should update our command so the new ones can be played.

Describe the solution you'd like
Check for new activies, and add the ones we can play.
@Tais993 Tais993 added enhancement New feature or request enhance command Modify or improve an existing command or group of commands of the bot priority: low labels Feb 11, 2022
@Tais993 Tais993 self-assigned this Feb 11, 2022
@illuminator3 illuminator3 added the good first issue Good for newcomers label Feb 12, 2022
@Zabuzard
Copy link
Member

What are the new acitivites? Where can we see them? Any link?

@Tais993
Copy link
Member Author

Tais993 commented Feb 14, 2022

Didn't assign "good first issue" for that reason.

Once I have the time to retrieve them I'll update this PR and someone else can try add them if they want ^^

@Tais993
Copy link
Member Author

Tais993 commented Feb 18, 2022 •
edited
Loading

Removed message, see message below for context

@Tais993 Tais993 removed their assignment Feb 18, 2022
@Tais993
Copy link
Member Author

Tais993 commented Mar 13, 2022

Update, found a Gist with more activities.
Seems YouTube Together does work, but has a new ID

@Korwai
Copy link
Contributor

Korwai commented Jul 27, 2022

Hellooo, may I try tackling this as a first issue?

@Zabuzard
Copy link
Member

Hi @Korwai :) Sure thing, thanks for considering. Its been some time this ticket was opened though, so I could imagine that the list of valid activities changed already. @Tais993 do you have an updated list maybe?

@Korwai
Copy link
Contributor

Korwai commented Jul 27, 2022 •
edited
Loading

I found this list (https://gist.github.com/GeneralSadaf/42d91a2b6a93a7db7a39208f2d8b53ad) when looking for IDs of VC activities and it seems updated but the one listed in the current documentation refers to this one (discord-jda/JDA#1628).

Any preference on which list I should refer to? ^^

Edit: Never mind, I scrolled up some more and found the same list Tais linked so I'll use that one. xd

@Zabuzard Zabuzard mentioned this issue Jul 28, 2022
Merged
@Zabuzard Zabuzard removed the enhance command Modify or improve an existing command or group of commands of the bot label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Korwai Korwai

Labels
enhancement New feature or request good first issue Good for newcomers priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated map of VC activities Korwai/TJ-Bot
4 participants
@Zabuzard @Korwai @illuminator3 @Tais993