-
-
Notifications
You must be signed in to change notification settings - Fork 89
Updated map of VC activities #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please fix the remaining spotless issues 👍 |
Good job @Korwai ! Lets keep it open for another day, so that others could react as well. And then we can merge it :) (Are you in our Discord server Together Java? If so, you would get a special badge for your contribution - couldnt find your name 😃) |
Thanks @Zabuzard :D I did join the Discord earlier today, my tag should be Lulee#2000 ^^ |
In your post, you're saying fishington doesn't work. But it's added in the code. If it doesn't work, it shouldn't be added. |
I saw fishington.io and betrayal.io in the list beforehand so I kept them in there just for completionist-sake but I can remove them along with Sketchy Artist and Awkword if needed. |
I would vote for removing anything that doesnt work. I dont want users to have bad UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put chess game in a separate line
I doubt they can. This is most likely controlled by Spotless. |
application/src/main/java/org/togetherjava/tjbot/commands/basic/VcActivityCommand.java
Outdated
Show resolved
Hide resolved
7 days after last activity. Merging 🙂 |
What?
Updated names of activities to match Discord and added activities to the map.
Closes #378.
Why?
This should make the list of VC activities be up-to-date in terms of currently available activities.
How?
Adjusted variable values and changed the current VC_APPLICATION_TO_ID Map to work with Map.ofEntries() rather than Map.of() since the latter takes only up to 10 elements.
Testing?
I've tested every activity including the ones I've added and the ones that did not require a boost worked properly. I couldn't verify if the boost-required activities worked but the game icons did appear (except Sketchy Artist) when using the /vc-activity command.
Screenshots (optional)
Anything Else?
It seems like there are 4 games on the list that are not available to the public (Sketchy Artist, Awkword, Betrayal.io, Fishington.io) as Discord will return "This server doesn't have access to the requested activity."