Skip to content

Updated map of VC activities #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Conversation

Korwai
Copy link
Contributor

@Korwai Korwai commented Jul 28, 2022

What?

Updated names of activities to match Discord and added activities to the map.

Closes #378.

Why?

This should make the list of VC activities be up-to-date in terms of currently available activities.

How?

Adjusted variable values and changed the current VC_APPLICATION_TO_ID Map to work with Map.ofEntries() rather than Map.of() since the latter takes only up to 10 elements.

Testing?

I've tested every activity including the ones I've added and the ones that did not require a boost worked properly. I couldn't verify if the boost-required activities worked but the game icons did appear (except Sketchy Artist) when using the /vc-activity command.

Screenshots (optional)

Anything Else?

It seems like there are 4 games on the list that are not available to the public (Sketchy Artist, Awkword, Betrayal.io, Fishington.io) as Discord will return "This server doesn't have access to the requested activity."

@Korwai Korwai requested review from a team as code owners July 28, 2022 00:53
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2022

CLA assistant check
All committers have signed the CLA.

Zabuzard
Zabuzard previously approved these changes Jul 28, 2022
@Zabuzard
Copy link
Member

Please fix the remaining spotless issues 👍

@Zabuzard Zabuzard added enhance command Modify or improve an existing command or group of commands of the bot priority: low labels Jul 28, 2022
Zabuzard
Zabuzard previously approved these changes Jul 28, 2022
Taz03
Taz03 previously approved these changes Jul 28, 2022
@Zabuzard
Copy link
Member

Good job @Korwai ! Lets keep it open for another day, so that others could react as well. And then we can merge it :)

(Are you in our Discord server Together Java? If so, you would get a special badge for your contribution - couldnt find your name 😃)

@Korwai
Copy link
Contributor Author

Korwai commented Jul 28, 2022

Thanks @Zabuzard :D

I did join the Discord earlier today, my tag should be Lulee#2000 ^^

@Tais993
Copy link
Member

Tais993 commented Jul 28, 2022

In your post, you're saying fishington doesn't work. But it's added in the code.

If it doesn't work, it shouldn't be added.

@Korwai
Copy link
Contributor Author

Korwai commented Jul 28, 2022

I saw fishington.io and betrayal.io in the list beforehand so I kept them in there just for completionist-sake but I can remove them along with Sketchy Artist and Awkword if needed.

@Zabuzard
Copy link
Member

I saw fishington.io and betrayal.io in the list beforehand so I kept them in there just for completionist-sake but I can remove them along with Sketchy Artist and Awkword if needed.

I would vote for removing anything that doesnt work. I dont want users to have bad UX.

@Korwai Korwai dismissed stale reviews from Taz03 and Zabuzard via 9a30ca4 July 29, 2022 07:40
Zabuzard
Zabuzard previously approved these changes Jul 29, 2022
@Zabuzard Zabuzard requested a review from Taz03 July 29, 2022 08:06
Copy link
Member

@Taz03 Taz03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put chess game in a separate line

@Zabuzard
Copy link
Member

put chess game in a separate line

I doubt they can. This is most likely controlled by Spotless.

Taz03
Taz03 previously approved these changes Jul 29, 2022
@Korwai Korwai dismissed stale reviews from Taz03 and Zabuzard via 582a4a8 July 29, 2022 20:10
@Zabuzard Zabuzard requested review from Tais993 and Taz03 August 1, 2022 06:49
@Zabuzard
Copy link
Member

Zabuzard commented Aug 5, 2022

7 days after last activity. Merging 🙂

@Zabuzard Zabuzard merged commit d58506f into Together-Java:develop Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update VC activities command with new activities
5 participants