Skip to content

Java RSS Feed #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Apr 13, 2024
Merged

Java RSS Feed #1037

merged 54 commits into from
Apr 13, 2024

Conversation

nateweisz
Copy link
Contributor

@nateweisz nateweisz commented Feb 28, 2024 •
edited by ankitsmt211
Loading

Contains config changes

#882

This PR adds support for forwarding RSS feed's to a discord channel. It supports as many different URLs as you would like.

Screenshots

image

TODO

  • Have both text channel patterns, with the targetChannelPattern as an optional, and the javaNewsChannelPattern acting as the fallback.
  • Send the RSS posts in an ascending order by date such that the most recent post is sent last.
  • before merge remove 183ce42

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Together-Java Together-Java deleted a comment from nateweisz Feb 28, 2024
@nateweisz nateweisz marked this pull request as ready for review February 29, 2024 17:24
@nateweisz nateweisz requested review from a team as code owners February 29, 2024 17:24
@christolis christolis force-pushed the feat/java-mail-feed branch 2 times, most recently from 8605901 to 431004e Compare February 29, 2024 17:34
@christolis christolis requested a review from SquidXTV February 29, 2024 17:36
@christolis christolis added enhancement New feature or request priority: normal labels Feb 29, 2024
@Alathreon
Copy link
Contributor

Please explain in the description what is this pr.

@Alathreon Alathreon linked an issue Feb 29, 2024 that may be closed by this pull request
Java Mail RSS Forwarder #882
Closed
Alathreon
Alathreon requested changes Feb 29, 2024
View reviewed changes
@christolis christolis force-pushed the feat/java-mail-feed branch from a35ba72 to f9cf078 Compare March 1, 2024 17:25
@christolis christolis requested a review from Alathreon March 1, 2024 23:36
SquidXTV
SquidXTV requested changes Mar 5, 2024
View reviewed changes
SquidXTV
SquidXTV previously approved these changes Mar 5, 2024
View reviewed changes
Alathreon
Alathreon reviewed Mar 9, 2024
View reviewed changes
@christolis christolis force-pushed the feat/java-mail-feed branch 2 times, most recently from 6e6ccb2 to 6a2314c Compare March 10, 2024 19:18
@christolis christolis requested a review from Alathreon March 10, 2024 20:13
Alathreon
Alathreon requested changes Mar 17, 2024
View reviewed changes
christolis and others added 11 commits April 4, 2024 09:25
@christolis
docs: add a few missing parameters and fix typos
34974e5
@christolis
refactor: reduce try-catch scope and added clarifying comment
e284315
@christolis
perf: use Stream instead of StringBuilder
9deaa02
@christolis
refactor: put fallback case into an else statement
237d6ba
@christolis
refactor: switch to Map#containsKey() for targetChannelPatterns
b48c327
@christolis
feat: modularize sendRss() method and improve variable names
e257595 
This also changes the functionality of how new RSS feeds get dealt with
for the first time. Before this commit, all items would get posted as
embeds on Discord, and as a result, that would bombard the target
channel with RSS posts once the routine executes.

This commit changes this behavior by assuming that all RSS posts have
been posted and it should only consider posting posts newer than the
registered date.
@christolis
refactor: remove star import
18135e6
@christolis
fix: add Objects#requireNonNull() on rssConfig
48f0e76
@christolis
changes
6f9e2dd
@christolis @nateweisz
feat: improvements from code reviews
7f14bc2 
Co-authored-by: Nathan Weisz <151496498+nateweisz@users.noreply.github.com>
@christolis
feat: add DateTimeParseException in signature
82fd9b7
@christolis christolis force-pushed the feat/java-mail-feed branch from 9f9e2ab to 82fd9b7 Compare April 4, 2024 06:25
SquidXTV
SquidXTV requested changes Apr 8, 2024
View reviewed changes
@ankitsmt211 ankitsmt211 requested a review from Alathreon April 8, 2024 17:04
Taz03
Taz03 requested changes Apr 9, 2024
View reviewed changes
nateweisz and others added 2 commits April 9, 2024 06:32
@nateweisz @Taz03
fixed missing coma after rss configuration
cf67e4d 
Co-authored-by: Tanish <tanishazad03@gmail.com>
@nateweisz
fix(rss): feeds support multiple channels
2fb249f 
fix(rss): polling interval is now clear on unit of time
fix(rss): posting messages now uses forEachOrdered
SquidXTV
SquidXTV requested changes Apr 9, 2024
View reviewed changes
@nateweisz nateweisz requested a review from Taz03 April 13, 2024 16:32
@christolis christolis merged commit 835a951 into Together-Java:develop Apr 13, 2024
@ankitsmt211 ankitsmt211 mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christolis christolis christolis left review comments

@Alathreon Alathreon Alathreon approved these changes

@Taz03 Taz03 Taz03 approved these changes

@SquidXTV SquidXTV SquidXTV approved these changes

Assignees

@christolis christolis

@nateweisz nateweisz

Labels
enhancement New feature or request priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java Mail RSS Forwarder
6 participants
@nateweisz @CLAassistant @Alathreon @christolis @Taz03 @SquidXTV