GitHub Reference feature is in wrong package #1019 #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Taz03
previously approved these changes
Mar 2, 2024
|
Great job @Jayanta-karmakar! Only thing that's left to do now is to get the Spotless checks to pass. Was the pre-commit hook executed when creating the commit? You should use the command |
Taz03
previously approved these changes
Mar 2, 2024
SquidXTV
previously requested changes
Mar 4, 2024
|
Okay @SquidXTV, I will Fix it |
|
I have checked everything and checked all the code and ran all the tests... it looks good to me |
ankitsmt211
reviewed
Mar 6, 2024
application/src/main/java/org/togetherjava/tjbot/features/github/GitHubReference.java
Outdated
Show resolved
Hide resolved
Taz03
previously approved these changes
Mar 20, 2024
Taz03
approved these changes
Mar 20, 2024
ankitsmt211
approved these changes
Mar 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1019
The GitHub reference feature is located in the
commands.githubbut should be infeatures.githubinstead like any other feature. so, I rebasedcommands.githubtofeatures.github, and made some methods public so that they can be accessible.