Feature/logging-for-disabled-features #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
christolis
requested changes
Mar 8, 2024
Member
christolis
left a comment
christolis
left a comment
There was a problem hiding this comment.
Welcome to the TJ-Bot project! I left some review comments. It looks like the pre-commit hook didn't execute when making the commit, so try running the spotlessApply task from Gradle (./gradlew spotlessApply) to fix this and so that the tests pass. 🙌
application/src/main/java/org/togetherjava/tjbot/config/FeatureBlacklist.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/config/FeatureBlacklist.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/code/CodeMessageHandler.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@christolis I have done the changes. |
illuminator3
approved these changes
Mar 9, 2024
java-coding-prodigy
previously requested changes
Mar 10, 2024
application/src/main/java/org/togetherjava/tjbot/config/FeatureBlacklist.java
Show resolved
Hide resolved
Taz03
approved these changes
Mar 13, 2024
This was referenced Mar 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is continuing #898 - which is the logging for disabled features (I am Tea from the discord server)
I was implementing the change requests at #899 from the assignees code since that PR has been quite inactive, so i've added only small modifcations.
Although, one change requested to use "Stream<? extends F>" at the disableMatching method at FeatureBlacklist class, however this was causing some problems since at the Features class the return type of its method is just "Features" so i am unsure how to go forward with that particular modifcation.
However everything works and I tested it
Credit to @adiChoudhary for doing most of it at #899 , i just finished things off