-
-
Notifications
You must be signed in to change notification settings - Fork 89
Remove star imports #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove star imports #1092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not sure if merging this will close the issue but we can re-open it I guess, just to update Sonar/any linting we have to flag * imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a sonar / checkstyle check to prevent this from happening again (as stated in the issue)
True, it's a partial resolution. But generally I prefer configuration and code changes in 2 separate PRs. As this will have no direct impact, but merging it will prevent PRs. While changing sonar configuration might for open PRs. |
...ation/src/main/java/org/togetherjava/tjbot/features/moderation/audit/ModAuditLogRoutine.java
Outdated
Show resolved
Hide resolved
application/src/test/java/org/togetherjava/tjbot/features/mathcommands/TeXCommandTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Removes star imports. Resolves #1057