Skip to content

Remove star imports #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 12, 2024

Conversation

SimonVerhoeven
Copy link
Contributor

Removes star imports. Resolves #1057

@SimonVerhoeven SimonVerhoeven requested a review from a team as a code owner April 16, 2024 19:34
tj-wazei
tj-wazei previously approved these changes Apr 16, 2024
Copy link

@tj-wazei tj-wazei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm not sure if merging this will close the issue but we can re-open it I guess, just to update Sonar/any linting we have to flag * imports.

Taz03
Taz03 previously requested changes Apr 17, 2024
Copy link
Member

@Taz03 Taz03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a sonar / checkstyle check to prevent this from happening again (as stated in the issue)

@SimonVerhoeven
Copy link
Contributor Author

LGTM

I'm not sure if merging this will close the issue but we can re-open it I guess, just to update Sonar/any linting we have to flag * imports.

True, it's a partial resolution. But generally I prefer configuration and code changes in 2 separate PRs. As this will have no direct impact, but merging it will prevent PRs. While changing sonar configuration might for open PRs.

Copy link
Member

@SquidXTV SquidXTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Taz03 Taz03 dismissed their stale review May 7, 2024 13:46

dismiss

@tj-wazei tj-wazei merged commit d198f19 into Together-Java:develop May 12, 2024
9 checks passed
@ankitsmt211 ankitsmt211 mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove star imports
4 participants