Fix: Pinned Threads Archiving Issue #1084 #1104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
A fix for this is already merged ( #1088 ) |
|
Ideally first look if a ticket's already assigned, and whether there's already an open pull request for it. |
|
Okay, thanks |
|
@JayBhensdadia Hi, will be closing this PR soon unless you any further questions. |
|
No, I don't have any questions |
|
sweet, hope to see you around :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves the problem outlined in issue #1084, where pinned threads in the "questions" forum were being archived by the auto-archiving routine.
Testing:
For testing purposes i used SCHEDULE_MINUTES = 1 and ARCHIVE_AFTER_INACTIVITY_OF = 100 seconds
Screenshots:
After INACTIVITY
Screen recording of test