Skip to content

Create .gitattributes #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

Create .gitattributes #1108

merged 1 commit into from
May 13, 2024

Conversation

surajkumar
Copy link
Contributor

Created a .gitattributes to enforce LF encoding. On Windows when I ran spotless, it changes the line encoding to CFRL which is incorrect.

@surajkumar surajkumar requested a review from a team as a code owner May 12, 2024 17:31
Zabuzard
Zabuzard requested changes May 13, 2024
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about existing code? If this is ticked, will tooling suddenly report that some existing code has the wrong file endings?
If so, it has to be changed in the same PR as well.

Zabuzard
Zabuzard approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(wazei says on discord that all files are already LF)

@Zabuzard Zabuzard merged commit f045ccf into Together-Java:develop May 13, 2024
9 checks passed
@surajkumar surajkumar deleted the gitattributes branch May 13, 2024 18:18
@ankitsmt211 ankitsmt211 mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@tj-wazei tj-wazei tj-wazei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surajkumar @Zabuzard @tj-wazei