Tag system

[illuminator3]

This PR adds a tag system & commands to use it. Closes #61.

Implemented commands are:

• /tag <id> to view a tag
• /tags to view all tags

and management commands

• /tag-manage raw <id> to view the raw contents of a tag
• /tag-manage create <id> <content> to create a tag with given content
• /tag-manage create-with-message <id> <message-id> to create a tag based on the content of an existing message
• /tag-manage edit <id> <content> to edit a tag with given content
• /tag-manage edit-with-message <id> <message-id> to edit a tag based on the content of an existing message
• /tag-manage delete <id> to delete an existing tag

The with-message overloads for create and edit are necessary and super useful when having more complex content with code formatting and similar, since slash commands do not support newlines.

[illuminator3]

Seems like I forgot to add javadoc, will add it now

[Tais993]

Well done.

While I would strongly prefer it if you made usage of sub-commands instead.
Makes it easier for the user and will allow a ton more commands.

This in total is 8 commands while it could be 1.

[illuminator3]

While I would strongly prefer it if you made usage of sub-commands instead.

I first thought about that as well, but it would be kinda confusing for new users to do /tag view <id> instead of just /tag <id>. I could maybe do sub commands with a /tagmanage <create|edit|delete> or /managetag.

[Tais993]

While I would strongly prefer it if you made usage of sub-commands instead.

I first thought about that as well, but it would be kinda confusing for new players to do /tag view <id> instead of just /tag <id>. I could maybe do sub commands with a /tagmanage <create|edit|delete> or /managetag.

Do like the idea of a separate tagmanage command, even better than one for all

[illuminator3]

While I would strongly prefer it if you made usage of sub-commands instead.

I first thought about that as well, but it would be kinda confusing for new players to do /tag view <id> instead of just /tag <id>. I could maybe do sub commands with a /tagmanage <create|edit|delete> or /managetag.

Do like the idea of a separate tagmanage command, even better than one for all

Yea, I'll implement it!

outdated

[Tais993]

I approve it.

Still I'll mention that it's maybe nice to replace some of the code in the switch with methods?
Just a suggestion, the code is good. 👍

[Tais993]

You're cute keep it up

[Tais993]

Make sure you're logged in when trying

[Zabuzard]

Rebase on develop

[Zabuzard]

NotNull found out that the MarkdownSanitizer.escape(...) does not correctly escape \\. It leaves it as \\ instead of making \\\\. We have to test whether the raw-command works with such input and whether its an actual issue in practice (thinking about code comments for example).

All changes have been implemented.

[Zabuzard]

NotNull found out that the MarkdownSanitizer.escape(...) does not correctly escape \\. It leaves it as \\ instead of making \\\\. We have to test whether the raw-command works with such input and whether its an actual issue in practice (thinking about code comments for example).

It was indeed a problem. I pushed code to fix it now.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

0.0% Coverage
0.0% Duplication