-
-
Notifications
You must be signed in to change notification settings - Fork 89
Migrate /warn command #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate /warn command #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before looking at the code, I am proposing to change the UX to:
/warn user reason
and then having a separate
/audit user
command which shows:
- all warnings
- all bans
- all kicks
- all mutes
(with reason)
(it is okay if the command can only capture actions that have been executed with this bot - no need to check the actual audit log)
So are you saying i just delete the retrieve part. |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
Dont request a new review from me unless you think you fixed all my mentioned issues. You know the story of the boy who cried for the wolf and then nobody believed him and came anymore when the real wolf was there? This is kinda how I feel like when you do this. It has the opposite effect of what you want to achieve, namely that I will delay my review and ignore your "requests". |
Ok I will improve on that note |
Blocked by #244 |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ActionRecord.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
The issue with ActionRecord was resolved but does not appear on Github which is a problem for their side. @Zabuzard just letting you know
The commit history of this PR is absolutely terrible. It must be squashed or rewritten. DO NOT REBASE THIS, IT MUST BE SQUASHED (or rewritten first) |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/WarnCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/utils/MessageUtils.java
Outdated
Show resolved
Hide resolved
Added the space back and added Why you want to warn the user
Overview
This adds the
/warn user reason
command, which lets moderators warn users. Warnings can then be later retrieved using/audit
(#312 ).As usual, the command will try to DM the target to inform them about the action, have the usual permission checks (heavy moderation role in this case) and similar. Nothing really special to see here.
Part of #63 .