Up- and down-voting on suggestions

[Zabuzard]

Overview

Implements and closes #375. Added a message listener SuggestionsUpDownVoter which listens to all messages in suggestion channels (config) and reacts with an up- and down-vote to them:

The emotes are configurable and fallback to the default 👍 and 👎 in case the server does not have them (together with a logger warning).

Config

The config had to be adjusted for this, please add the following (see the adjusted config.json.template):

"suggestions": {
    "channelPattern": "tj_suggestions",
    "upVoteEmoteName": "peepo_yes",
    "downVoteEmoteName": "peepo_no"
}

[marko-radosavljevic]

Maybe we should use some custom/unique 👍 so it's clear that it's upvote for our suggestions, and maybe something just the bot can use, if possible? Since we want to convey that it's a 'special' upvote button, not just a random, very common reaction emoji.

Also, because I assume, we can't lock who can react to each suggestion it can be confusing to people how to actually vote.

Currently, humans are reviewing each suggestion, which means there is quite a bit of flexibility in determining what's upvote and what's downvote. But still, it would be nice to standardize this to make it easier for everyone.

---

Slightly unrelated to this,

It's nice that you can easily search, and find each suggestion on this panel, issue is – there are no votes. So you can search and find a thread, but to vote, to check the current voting progress, you need to scroll suggestions and find the original message that is being voted on. Which is poor UX. It would be ideal if this kind of separation didn't exist.

Once you click on thread, you get teleported and lose all the original information. They are at completely different places, functionally. And you are incentivized to use threads in this exact manner. If you click one of these, the teleportation also happens:

Or that view from the picture before..

Not sure how to remedy this in a sensible way tho, maybe the bot can decorate the thread title with (somewhat) current voting count? Doesn't seem ideal, and also that way you just get the votes, but not original suggestion body.

Another issue with this is that people usually write terrible thread names, so just from the thread name, you have no idea what was the original suggestion.

[Tais993]

wops

[Zabuzard]

@marko-radosavljevic I dont quite follow your suggestion regarding custom emojis only the bot can use.

The point of pre-adding the votes is to make it easier and more obvious for users how the system works. I.e. they can just click on one of the existing votes.

I mean sure, we can replace that by other emojis but why should only the bot be allowed to react? Or what did you mean?

[Tais993]

@marko-radosavljevic if you didn't know, you can press on "jump" to "jump" to the old message.

[marko-radosavljevic]

@Zabuzard

Yeah, sorry, obviously other people should be able to react with the same emote. :D

I'm mostly thinking about having a custom upvote/downvote, just so it's more obvious that it's our 'special' button for voting. Can be confusing to a person unfamiliar with the system if there are 15 reactions on the suggestion, and they are all very common emojis.

It would be best if only 2 emotes were possible for each suggestion, but it's probably something we can't control with the current system.

Edit: To be really concrete, and avoid misunderstanding. What I'm suggesting is, add one of these as new emoji on the server, with name :approve-suggestion: or similar. ☺️

@Tais993

Oh, I didn't know this, that's exactly what I need. :D

I notice some of them don't have jump button, but thanks, will experiment more with it. ❤️

[Zabuzard]

@marko-radosavljevic Added custom emotes (via config) with fallbacks.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[marko-radosavljevic]