Skip to content

Fixing thread help system bugs #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Fixing thread help system bugs #452

merged 2 commits into from
Jun 15, 2022

Conversation

Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Jun 14, 2022

Overview

We recently pushed the new thread based help system and quickly discovered a couple of bugs. This PR fixes most of the known issues:

  • /ask command with too long title:

ask too long title

  • just uploading a file, no actual text content:

file upload

  • issue with rate limits on /change-help-category

channel rename

  • issue with rate limits on /close

close

  • title containing invalid characters

@Zabuzard Zabuzard added bug Something isn't working enhance command Modify or improve an existing command or group of commands of the bot priority: major labels Jun 14, 2022
@Zabuzard Zabuzard added this to the Improvement phase 1 milestone Jun 14, 2022
@Zabuzard Zabuzard requested review from a team as code owners June 14, 2022 06:45
@Zabuzard Zabuzard self-assigned this Jun 14, 2022
@Zabuzard Zabuzard force-pushed the bugfix/thread_help_system branch from e5ef0e2 to c64b485 Compare June 14, 2022 06:53
Zabuzard added 2 commits June 14, 2022 08:57
* /ask command with too long title
* implicit ask with bad title (file upload or invisible spaces, ...)
* close command
* change category command
@Zabuzard Zabuzard force-pushed the bugfix/thread_help_system branch from c64b485 to 726712e Compare June 14, 2022 06:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard Zabuzard merged commit b797ffa into develop Jun 15, 2022
@Zabuzard Zabuzard deleted the bugfix/thread_help_system branch June 15, 2022 06:44
@Zabuzard
Copy link
Member Author

Merging to speed up testing and release of the main feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhance command Modify or improve an existing command or group of commands of the bot priority: major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant