Bugfix when creating help threads, no bot-messages #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an attempt to fix the current, frequent, bug where help threads are missing the bot explanation messages.
Explanation
They are caused by an exception:
The source of this is most likely that
overviewChannel.createThreadChannel(...)
is rate limitted and hence executed a few seconds later. At which point the subsequentevent.refer(...)
crashes with Unknown interaction cause it is past the 3 seconds threshold. The extra messages are then missing, cause they areflatMap
'ed right after the failingnotifyUser(...)
:Solution
The solution introduced in this PR is to simply make the whole interaction deferred. That way, the code has more time to respond, enough to fit in a delayed thread creation - hopefully.
There are also other alternatives available, such as changing the order of the statements or simply not letting the chain collapse on a single failure. But I would like to try out this fix first.