-
-
Notifications
You must be signed in to change notification settings - Fork 89
Gist auto filesharing in help threads #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(could you also share some screenshots?) |
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistFile.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistFile.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistResponse.java
Outdated
Show resolved
Hide resolved
...in/java/org/togetherjava/tjbot/commands/filesharing/ShareLongAttachmentsMessageListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/togetherjava/tjbot/commands/filesharing/ShareLongAttachmentsMessageListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/togetherjava/tjbot/commands/filesharing/ShareLongAttachmentsMessageListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/togetherjava/tjbot/commands/filesharing/ShareLongAttachmentsMessageListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/togetherjava/tjbot/commands/filesharing/ShareLongAttachmentsMessageListener.java
Outdated
Show resolved
Hide resolved
...in/java/org/togetherjava/tjbot/commands/filesharing/ShareLongAttachmentsMessageListener.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/package-info.java
Outdated
Show resolved
Hide resolved
Good job and thanks for the contribution, its an awesome feature 👍 |
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistFile.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistFiles.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistRequest.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistFiles.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Show resolved
Hide resolved
whats up with the delete button? |
look here: |
application/src/main/java/org/togetherjava/tjbot/commands/filesharing/GistResponse.java
Show resolved
Hide resolved
what about adding a slash command u need the delete the message after that too if u want to or u can just disable the button, i prefer deleting the message(to keep the chat clutter free) |
only sender of file + mods should have rights to use that command? |
also u can take message link and get the messageId from it, the reason for using message link over message id can be that for copying message id of a message u need to turn on developer mode on in discord settings, and some new users might not have that turned on so it'll save some time solving the "no copy id button" problem |
yes, tho im not sure about heavy mod or soft mod |
soft mod is fine for that |
Anyways, I would like to wrap this up as it is for now, get it shipped and then work on deletion in a separate PR, that okay for you @SquidXTV ? Long-living and big branches can be problematic to mantain, better ship smaller units. And mods can always manually delete gists by logging in to the bot account anyways. |
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/org/togetherjava/tjbot/commands/filesharing/FileSharingMessageListener.java
Show resolved
Hide resolved
ok no problem for me, gonna work on your pr comments and then I think it's done for this pr. |
Closes #489.
About
Automatically uploads files in help threads to gist and reply with the link to that gist.
It's easier to read files like that and longer files don't need to be downloaded.
ToDo:
Config changes:
Added gistApiKey to config for file-sharing uploads to gist using GitHub's API.
How to create this key:
GitHub -> Settings -> Developer Settings -> Personal Access Token -> Create new token
you can choose note and expiration date yourself, and in scopes select gist:

after that copy your key and add it to your config.json
see also: Create GitHub personal access token
Release
Config changes, added the following: