Skip to content

Added help thread activity detection #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Conversation

Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Aug 13, 2022

Overview

Closes #478 . This adds a activity indicator to each help thread:

  • 🔻: needs help
  • 🔸: likely needs help
  • 🔹: seems good

They indicate towards helpers which channels are in most need of help and which likely already received attention by helpers.

The code updates these indicators every 30 minutes (to not hit renaming rate limits). New threads start with 🔻.

discord overview

our overview

Details

The code determines activity based on a simple heuristic (bot messages are filtered):

  • 🔻: default
  • 🔸: <= 10 messages, at least 2 different people and one of them wrote >= 2 messages
  • 🔹: > 10 messages

@Zabuzard Zabuzard added enhancement New feature or request priority: normal labels Aug 13, 2022
@Zabuzard Zabuzard self-assigned this Aug 13, 2022
@Zabuzard Zabuzard requested review from a team as code owners August 13, 2022 12:42
@marko-radosavljevic
Copy link
Contributor

marko-radosavljevic commented Aug 13, 2022

Since we don't use emojis anywhere (in channel names, etc), this would add a lot of visual clutter and random colours and shapes everywhere. Especially if you are invited to lots of threads, your whole screen would light up like Vegas. They will even update periodically, and flicker. I feel like lots of people will dislike that, I know I would.

So maybe we can first go with something unoffensive like utf-8 characters.

Maybe:
× - needs help
– - likely needs help
✓ - seems good

Or something along those lines. We have a ton of options with utf chars.

Also, red-yellow-blue is unorthodox and possibly confusing, especially with the different shapes. Would rather have red-yellow-green with shapes that maybe represent their intended purpose better. I understand that we have somewhat limited options here. Not really a huge deal tho, since we would have a legend explaining the system, and regular helpers that use the inbox system will get accustomed relatively fast.

@Zabuzard
Copy link
Member Author

yes. i understand and i would be okay with ur suggestions. maybe we make a voting somewhere, to get a few more opinions.

@Zabuzard
Copy link
Member Author

Zabuzard commented Aug 13, 2022

ur symbols look like this @marko-radosavljevic :

changed

Personally, I like the color. But those symbols also do work.

@marko-radosavljevic
Copy link
Contributor

Yeah, I think it works. It's definitely unoffensive, and I think I would get used to it pretty quickly. Maybe it needs some detail to make it stand out better, dash or one more space, or circled characters.. Because it blends a bit with the title and the tag, it's supposed to be 'left' of it, as a separate element

Will see if I can think of anything else, and we can have a quick vote or something. Thanks ☺️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Taz03
Copy link
Member

Taz03 commented Aug 14, 2022

i prefer red green and yellow with uniform shapes

@Zabuzard
Copy link
Member Author

the "problem" with green and ✅ or ✔️ is that it feels like its for sure OK, handled and doesnt need any help anymore. But we are still talking about a heuristic only and just because there is a lot of traffic, doesnt mean the question has been answered. Hence I tried to go for something 🟦 that looks like "okay" but not "handled for sure".

@mikerasch
Copy link
Contributor

mikerasch commented Aug 15, 2022

I feel like there's no way to deliver an emoji-based system without it being a little confusing. Is it possible we could incorporate custom emojis? I feel like the current default emotes, it's lacking the goal of a non-confusing system.

Such as what you said previously if you add some sort of "green" or checkmark, it gives the impression the question is fulfilled and no longer needs help.

@Zabuzard
Copy link
Member Author

Zabuzard commented Aug 15, 2022

custom emojis are technically possibly, but harder to implement (u have to retrieve them via rest actions etc and have a fallback in case they are not available). and its even harder for the parsing part when u have to allow multiple symbols.

i would really like to avoid going down that rabbit hole.

anything unicode works though. so if you find more useful unicode symbols, thats fine.

@Zabuzard
Copy link
Member Author

We will go for this design for today and change it based on user feedback in the early days after release, i guess

@Zabuzard Zabuzard merged commit 7130b76 into develop Aug 19, 2022
@Zabuzard Zabuzard deleted the feature/help_thread_activity branch August 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Thread activity overview
4 participants