Skip to content

added auto-complete for tag command #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 15, 2022
Merged

added auto-complete for tag command #598

merged 29 commits into from
Oct 15, 2022

Conversation

Taz03
Copy link
Member

@Taz03 Taz03 commented Oct 1, 2022 •
edited
Loading

Added auto complete for tag command

image

closes #594

@Taz03 Taz03 requested review from a team as code owners October 1, 2022 05:26
@Taz03 Taz03 self-assigned this Oct 1, 2022
@Taz03 Taz03 added enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Oct 1, 2022
@Taz03 Taz03 requested a review from Tais993 October 2, 2022 20:39
@Taz03 Taz03 requested a review from Zabuzard October 4, 2022 06:52
@Zabuzard
Copy link
Member

Zabuzard commented Oct 4, 2022

Does this conflict with #602 ? Im confused.

Zabuzard
Zabuzard requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sth I just saw: This PR should remove the TODO at TagCommand line 42 that essentially asks about adding exactly this.

@Taz03
Copy link
Member Author

Taz03 commented Oct 5, 2022

Sth I just saw: This PR should remove the TODO at TagCommand line 42 that essentially asks about adding exactly this.

it says if the user calls this without id or similar and this pr never deals with that ig #602 does that

@Taz03 Taz03 requested a review from Zabuzard October 5, 2022 17:18
@Taz03
Copy link
Member Author

Taz03 commented Oct 6, 2022

ok

@Taz03 Taz03 requested a review from Zabuzard October 6, 2022 20:21
Zabuzard
Zabuzard requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve my existing issues, thanks

@Taz03 Taz03 requested a review from Zabuzard October 7, 2022 15:23
Zabuzard
Zabuzard requested changes Oct 8, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Zabuzard
Zabuzard approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before u merge, please have a final test over all edge cases. its easy to break stuff through longer rounds of CR if it doesnt have 100% unit test coverage 👍

@Taz03
Copy link
Member Author

Taz03 commented Oct 15, 2022

@Zabuzard one approve and been a whole week so merge now?

@Tais993
Copy link
Member

Tais993 commented Oct 15, 2022

Okay so I learned something new.
If GitHub says "change requested" it's useless and means nothing, as my review has been requested already.
I'll review RN

@Taz03 Taz03 merged commit 2b7ce2f into develop Oct 15, 2022
@Taz03 Taz03 deleted the autocomplete-tag-command branch October 15, 2022 19:34
@Zabuzard Zabuzard mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Tais993 approved these changes

Assignees

@Taz03 Taz03

Labels
enhance command Modify or improve an existing command or group of commands of the bot priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto-completion to /tag
3 participants
@Taz03 @Zabuzard @Tais993