Fixed components not working #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuminator3
previously approved these changes
Oct 3, 2022
|
Kudos, SonarCloud Quality Gate passed! |
illuminator3
approved these changes
Oct 3, 2022
Taz03
approved these changes
Oct 4, 2022
|
this is a design problem. the prefix was meant to be an internal detail only (inside |
|
Where does it leak to user API? You mean people that generate ides themself? I don't see a solution, that'd require a full rework again, which includes a rework of ID generation I think? I have no clue how this can be fixed, feel free to modify the system |
|
I fixed what I was annoyed by in #588 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BotCommandAdapter
the Interactor's name was used without prefix, but to forward from the button the prefix is needed.
I promise next time I'll create a better PR! :p