Skip to content

Bump Java Version to 20 #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2023
Merged

Bump Java Version to 20 #902

merged 3 commits into from
Oct 3, 2023

Conversation

@java-coding-prodigy
Copy link
Contributor

@java-coding-prodigy java-coding-prodigy commented Sep 24, 2023

Bump Java Version of the bot.
Please reflect the same on the website too

@java-coding-prodigy java-coding-prodigy requested review from a team as code owners September 24, 2023 14:15
@java-coding-prodigy
Copy link
Contributor Author

java-coding-prodigy commented Sep 24, 2023

Also had to upgrade gradle to 8.3 so there are a few changes from the upgrade as well

Taz03
Taz03 previously approved these changes Sep 24, 2023
View reviewed changes
@java-coding-prodigy
Copy link
Contributor Author

java-coding-prodigy commented Sep 25, 2023

The changes in WolframAlphaImages.java are required because URL#<init>(String is deprecated in Java 20 and the suggested alternative is to use URI#toURL.
This also changes the exception handling a little bit but functionally it is the same as what we were doing previously.

@Zabuzard Zabuzard added priority: normal dependencies Pull requests that update a dependency file labels Sep 26, 2023
@Zabuzard
Copy link
Member

Zabuzard commented Sep 26, 2023

make spotless and codeql happy please

@java-coding-prodigy
Copy link
Contributor Author

java-coding-prodigy commented Sep 27, 2023

make spotless and codeql happy please

For CodeQL to be fixed we need #903
Spotless is also having some weird error while trying to build, I’ll have to check that.

@java-coding-prodigy
Copy link
Contributor Author

java-coding-prodigy commented Sep 27, 2023 •
edited
Loading

make spotless and codeql happy please

For CodeQL to be fixed we need #903 Spotless is also having some weird error while trying to build, I’ll have to check that.

Apparently that isn’t the issue of CodeQL
For some reason Gradle 8.3 is not able to run files compiled by Java 20(Byte code version 64 is from Java 20) even though it is supposed to support Java 20
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard Zabuzard merged commit 0f3ab26 into develop Oct 3, 2023
@Zabuzard Zabuzard deleted the upgrade_java branch October 3, 2023 08:44
java-coding-prodigy added a commit that referenced this pull request Oct 6, 2023
@java-coding-prodigy
Bump Java Version to 20 (#902)
2b0034b 
* 19 -> 20

* change deprecated stuff

* make sonar happy
@java-coding-prodigy java-coding-prodigy mentioned this pull request Oct 6, 2023
Open
@Zabuzard Zabuzard mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Taz03 Taz03 Taz03 approved these changes

Assignees

@java-coding-prodigy java-coding-prodigy

Labels

dependencies Pull requests that update a dependency file priority: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@java-coding-prodigy @Zabuzard @Taz03