Skip to content

fix: Sometimes the commit user isn't set in check_suite events. #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toktok-releaser merged 1 commit into from
Feb 15, 2022
Merged

fix: Sometimes the commit user isn't set in check_suite events. #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,6 @@ on:
jobs:
build:
uses: TokTok/ci-tools/.github/workflows/haskell-ci.yml@master

common:
uses: TokTok/ci-tools/.github/workflows/common-ci.yml@master
6 changes: 3 additions & 3 deletions src/GitHub/Types/Base/Commit.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module GitHub.Types.Base.Commit where

import Data.Aeson (FromJSON (..), ToJSON (..),
object)
import Data.Aeson.Types (Value (..), (.:), (.=))
import Data.Aeson.Types (Value (..), (.:), (.:?), (.=))
import Data.Text (Text)
import Test.QuickCheck.Arbitrary (Arbitrary (..))

Expand All @@ -17,7 +17,7 @@ import GitHub.Types.Base.User

data Commit = Commit
{ commitSha :: Text
, commitUser :: User
, commitUser :: Maybe User
, commitRepo :: Maybe Repository
, commitLabel :: Text
, commitRef :: Text
Expand All @@ -27,7 +27,7 @@ data Commit = Commit
instance FromJSON Commit where
parseJSON (Object x) = Commit
<$> x .: "sha"
<*> x .: "user"
<*> x .:? "user"
<*> x .: "repo"
<*> x .: "label"
<*> x .: "ref"
Expand Down