Skip to content

Comments

Add invitation event data to organization event.#24

Merged
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:master
Dec 19, 2016
Merged

Add invitation event data to organization event.#24
iphydf merged 1 commit intoTokTok:masterfrom
iphydf:master

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Dec 19, 2016

Also, add support for page_build event.


This change is Reviewable

Also, add support for `page_build` event.
@robinlinden
Copy link
Member

Reviewed 17 of 17 files at r1.
Review status: all files reviewed at latest revision, 5 unresolved discussions.


web/GitHub/Types/Base/Invitation.hs, line 23 at r1 (raw file):

instance FromJSON Invitation where
    parseJSON (Object x) = Invitation
        <$> x .: "email"

.:->.:? since it's not a mandatory field?


web/GitHub/Types/Base/PageBuildError.hs, line 20 at r1 (raw file):

instance FromJSON PageBuildError where
    parseJSON (Object x) = PageBuildError
        <$> x .: "message"

.:->.:??


web/GitHub/Types/Base/PushCommit.hs, line 34 at r1 (raw file):

        <$> x .: "added"
        <*> x .: "author"
        <*> x .: "committer"

.:->.:??


web/GitHub/Types/Base/StatusCommit.hs, line 35 at r1 (raw file):

        <*> x .: "comments_url"
        <*> x .: "commit"
        <*> x .: "committer"

.:->.:??


web/GitHub/Types/Events/StatusEvent.hs, line 51 at r1 (raw file):

        <*> x .: "sha"
        <*> x .: "state"
        <*> x .: "target_url"

.:->.:??


Comments from Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 8215df0 into TokTok:master Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants