Skip to content

Rename references of admin_approved to adminApproved in reviewable.js. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iphydf merged 1 commit into from
Jan 8, 2017
Merged

Rename references of admin_approved to adminApproved in reviewable.js. #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions reviewable_script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ _.each(review.sentiments, function(sentiment) {
const lgtmBlockers = _.filter(assignees, username => !_.has(approvals, username));

// Part 4 Check that a trusted reviewer has a current LGTM.
const trustedReviewers = ['GrayHatter', 'iphydf', 'nurupo'];
const trustedReviewers = ['GrayHatter', 'iphydf', 'nurupo', 'robinlinden'];
const adminApproved = _.some(trustedReviewers, username => approvals[username]);

// Combine the above to compute final status
const completed = !unreviewedFiles.length && !unresolvedDiscussions.length && !lgtmBlockers.length && admin_approved;
const completed = !unreviewedFiles.length && !unresolvedDiscussions.length && !lgtmBlockers.length && adminApproved;

// Generate the status message
const pendingReviewers = _(fileBlockers)
.concat(discussionBlockers, lgtmBlockers, admin_approved ? [] : trustedReviewers)
.concat(discussionBlockers, lgtmBlockers, adminApproved ? [] : trustedReviewers)
.uniq()
.value();

Expand All @@ -94,7 +94,7 @@ if (lgtmBlockers.length) {
descriptionPieces.push(`${lgtmBlockers.length} assignee LGTMs are missing`);
}

if (!admin_approved) {
if (!adminApproved) {
descriptionPieces.push(`missing Admin LGTM at current revision.`);
}

Expand Down