Skip to content

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Apr 2, 2017

This change is Reviewable

@nicoonoclaste
Copy link
Member

:lgtm_strong:

Ideally, the sorting of datatype fields, esp. in the `User` type, should go in their own commit, but aside from that this seems good.

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nicoonoclaste
Copy link
Member

PS: I used lgtm_strong as I assume the CI failure is due to the rebase being needed after the switch from Server to Handlerin #77.


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@robinlinden
Copy link
Member

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf iphydf merged commit 7854f4a into TokTok:master Sep 3, 2017
@iphydf iphydf temporarily deployed to git-critique September 3, 2017 15:43 Inactive
@iphydf iphydf deleted the data-model branch September 3, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants