Skip to content

spdx_id and url in license can be null. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iphydf merged 1 commit into from
Jan 14, 2018
Merged

spdx_id and url in license can be null. #85

iphydf merged 1 commit into from
Jan 14, 2018

Conversation

@iphydf
Copy link
Member

@iphydf iphydf commented Jan 13, 2018 •
edited
Loading

This change is Reviewable

@iphydf iphydf temporarily deployed to git-critique January 13, 2018 20:07 Inactive
@iphydf iphydf changed the title spdx_id in license can be null. spdx_id and url in license can be null. Jan 13, 2018
@iphydf iphydf temporarily deployed to git-critique January 13, 2018 20:11 Inactive
@iphydf iphydf force-pushed the maybe-spdx branch 4 times, most recently from 60f0f49 to eed8798 Compare January 13, 2018 20:18
@iphydf
spdx_id and url in license can be null.
2b079bc 
Also, add DeploymentPayload type. We now probably know what's in it.
@iphydf iphydf temporarily deployed to git-critique January 13, 2018 20:18 Inactive
@robinlinden
Copy link
Member

robinlinden commented Jan 14, 2018

:lgtm_strong:

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@iphydf iphydf merged commit 2b079bc into TokTok:master Jan 14, 2018
@iphydf iphydf deleted the maybe-spdx branch January 14, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@robinlinden robinlinden

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iphydf @robinlinden