Feature/whitelist images by token #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, some improvements applied:
|
|
I am happy with this. One last thing - can we please rename "Disclaimer" to "Image Preview Disclaimer". It is just being called just Disclaimer is not really saying what it is. And Disclaimer title and the exclamation icon can be one row, like we have in our warnings. e.g 🙏🏽 Thank you. |
|
Changes implemented as described by @piggydoughnut |
|
Looks great 🆗 @rannyeribaptist All go from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, back in here for another improvement! 🚀
I've been working on issue #200 for a while now, and it's finally here. I have added the disclaimer text along with 2 buttons for every token view. So you have the option to see it once, or to trust that token and never be prompted with the disclaimer for that specific token again.
I also thought it was a good idea to add a button to hide the token, so if you accidentally clicked to trust the token but you didn't want to, you can undo it.
All these behaviors can be seen in the video below:
token_white_list_demo.mov
closes #200