#233: Replaced PackedByteArray with PackedInt32Array #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #233 was caused by the fact that PackedByteArray was used to store regions' indices.
The code incremented actual index by 1.
Hence the 255th region had index 256 in the _region_map. However 256 overlows 8-bit, hence the bug occured.
I replaced PackedByteArray with PackedInt32Array, which solved the issue.
Fixes #233