Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Instancer working w/ vertex spacing #521

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TokisanGames
Copy link
Owner

@TokisanGames TokisanGames commented Oct 10, 2024

Fixes #479

To test at spacing <1, 1, >1

  • painting, w/ slope and ALT slope
  • erasing, w/slope and ALT slope
  • Saving & reloading
  • Removing regions where instances were created at all scales to ensure the instances are attached to the proper region
  • Sculpting underneath instances

Key reminder: ALT to inverse slope. CTRL+SHIFT to remove all instances.

The only thing I've seen is if you remove a region when vertex_spacing != 0, the instances in an adjacent region transform slightly. They aren't removed nor moved, but they seem to grow, shrink, or shear slightly. It isn't noticable at vertex_spacing 1. It may be due to the way we're scaling the MMI laterally only.

Remaining issues from first commit:

  • update_transforms < 1 doesn't work
  • Vertex spacing transforms the MMI!! And working on fixing this broke everything else.

@TokisanGames TokisanGames added the bug Something isn't working label Oct 10, 2024
@TokisanGames TokisanGames added this to the 0.9 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertex spacing >= 2 issues
1 participant