This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix 2964:英語のメニューリンクをホバーまたは押したときに文字幅が変わってしまう問題を修正 #7035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meiryo7743
reviewed
Jan 5, 2022
Comment on lines
99
to
100
| &.nuxt-link-exact-active { | ||
| font-weight: 600; | ||
| text-shadow: 0 0 1px $gray-1; |
There was a problem hiding this comment.
99 行目からの .nuxt-link-exact-active に対しては，文字色に合わせて $green-1 を指定するのが良さそうです。あるいは，currentColor としても問題ないでしょう。
Suggested change
| &.nuxt-link-exact-active { | |
| font-weight: 600; | |
| text-shadow: 0 0 1px $gray-1; | |
| &.nuxt-link-exact-active { | |
| text-shadow: 0 0 1px $green-1; |
ご参考までに，その差異を以下に示します。
$gray-1 |
$green-1 または currentColor |
|---|---|
 |
 |
There was a problem hiding this comment.
レビューありがとうございます！修正させていただきました
-
before
-
after
kaizumaki
approved these changes
Jan 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決する issue / Resolved Issues
📝 関連する issue / Related Issues
⛏ 変更内容 / Details of Changes
:hover:active.nuxt-link-exact-active📸 スクリーンショット / Screenshots
before
after
動作確認環境