Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add https:// when no schema is specified #536

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: Add https:// when no schema is specified #536

merged 1 commit into from
Nov 5, 2024

Conversation

TomBursch
Copy link
Owner

No description provided.

@TomBursch TomBursch added the enhancement New feature or request label Nov 5, 2024
@TomBursch TomBursch linked an issue Nov 5, 2024 that may be closed by this pull request
Feature request: Allow server addresses without a scheme #515
Closed
@TomBursch TomBursch merged commit fbc7b47 into main Nov 5, 2024
2 checks passed
@TomBursch TomBursch deleted the 515-feature-request-allow-server-addresses-without-a-scheme branch November 5, 2024 15:33
@sevenrats
Copy link

Interpretive logic for this purpose: https://github.com/jellyfin/jellyfin-roku/blob/2429a573cbaec7428a27790d3612fd387899afb6/source/utils/misc.bs#L203

In brightscript:
https://github.com/RA341/jellyflix/blob/e37e4c8c363c4cb9443facd8a38a364927dfe7fd/lib/services/auth_service.dart#L76

@TomBursch
Copy link
Owner Author

@sevenrats thanks! I've made it a bit simpler and just added https:// if the string doesn't contain http. I think that's good enough for now 😂 Will make it more robust in the future™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Allow server addresses without a scheme
2 participants
@TomBursch @sevenrats