Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct shift on hcount write. #1456

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Correct shift on hcount write. #1456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
972619c
Correct shift on hcount write.
TomHarte Jan 13, 2025
1b1a0f5
Keep three least bits.
TomHarte Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Machines/Commodore/Plus4/Video.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ struct Video {
video_mode_ = VideoMode::Text;
}
}

// printf("Mode: %d %d %d -> %d\n", bitmap_mode_, extended_colour_mode_, multicolour_mode_, int(video_mode_));
};

switch(address) {
Expand Down Expand Up @@ -169,7 +167,8 @@ struct Video {
case 0xff1d: vertical_counter_ = (vertical_counter_ & 0xff00) | value; break;
case 0xff1e:
// TODO: possibly should be deferred, if falling out of phase?
horizontal_counter_ = (horizontal_counter_ & 0x07) | ((~value << 2) & 0x1f8);
horizontal_counter_ = (horizontal_counter_ & 0x07) | ((~value << 1) & ~0x07);
horizontal_counter_ &= 0x1ff;
break;
case 0xff1f:
vertical_sub_count_ = value & 0x7;
Expand Down
Loading