theme manager: fix path to assets for PyInstaller on POSIX systems #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid referencing the assets directory as relative to the `customtkinter/windows/widgets/theme`, which does not exist in PyInstaller-frozen applications due to python modules being collected into executable-embedded archive. Relative referencing from non-existant directories, such as `customtkinter/windows/widgets/theme/../../../assets` does not work on POSIX systems (Linux and macOS) and results in file-not-found errors even though the actual target directory (`customtkinter/assets`) and its contents exist. Instead, resolve the top-level `customtkinter` directoy and its assets sub-directory via the pattern that is found in other parts of the code (i.e., use `os.dirname` to jump to parent directories from `__file__` location).
|
Cross-reference: pyinstaller/pyinstaller-hooks-contrib#542 |
|
Superseded by 121f571. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid referencing the assets directory as relative to the
customtkinter/windows/widgets/theme, which does not exist in PyInstaller-frozen applications due to python modules being collected into executable-embedded archive.Relative referencing from non-existant directories, such as
customtkinter/windows/widgets/theme/../../../assetsdoes not work on POSIX systems (Linux and macOS) and results in file-not-found errors even though the actual target directory (customtkinter/assets) and its contents exist.Instead, resolve the top-level
customtkinterdirectoy and its assets sub-directory via the pattern that is found in other parts of the code (i.e., useos.dirnameto jump to parent directories from__file__location).