Fix error message accuracy (#31)

TomasVotruba · Mar 15, 2024 · 86f3e7c · 86f3e7c
1 parent a2f456d
commit 86f3e7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/Rules/ReturnTypeCoverageRule.php b/src/Rules/ReturnTypeCoverageRule.php
@@ -23,7 +23,7 @@
     /**
      * @var string
      */
-    public const ERROR_MESSAGE = 'Out of %d possible return types, only %d - %.1f %% actually have it. Add more return types to get over %d %%';
+    public const ERROR_MESSAGE = 'Out of %d possible return types, only %d - %.1f %% actually have it. Add more return types to get over %s %%';
 
     public function __construct(
         private TypeCoverageFormatter $typeCoverageFormatter,

diff --git a/src/ValueObject/TypeCountAndMissingTypes.php b/src/ValueObject/TypeCountAndMissingTypes.php
@@ -36,7 +36,10 @@ public function getMissingTypeLinesByFilePath(): array
 
     public function getCoveragePercentage(): float
     {
-        return 100 * ($this->getTypedCount() / $this->totalCount);
+        $relative = 100 * ($this->getTypedCount() / $this->totalCount);
+
+        // round down with one decimal, to make error message clear that required value is not reached yet
+        return floor($relative * 10) / 10;
     }
 
     private function getTypedCount(): int