Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message accuracy #31

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix error message accuracy #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Rules/ReturnTypeCoverageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/**
* @var string
*/
public const ERROR_MESSAGE = 'Out of %d possible return types, only %d - %.1f %% actually have it. Add more return types to get over %d %%';
public const ERROR_MESSAGE = 'Out of %d possible return types, only %d - %.1f %% actually have it. Add more return types to get over %s %%';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we need this change only for return-types, but not property and param types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Let me add a new PR with the change to the other two messages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33


public function __construct(
private TypeCoverageFormatter $typeCoverageFormatter,
Expand Down
5 changes: 4 additions & 1 deletion src/ValueObject/TypeCountAndMissingTypes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ public function getMissingTypeLinesByFilePath(): array

public function getCoveragePercentage(): float
{
return 100 * ($this->getTypedCount() / $this->totalCount);
$relative = 100 * ($this->getTypedCount() / $this->totalCount);

// round down with one decimal, to make error message clear that required value is not reached yet
return floor($relative * 10) / 10;
}

private function getTypedCount(): int
Expand Down
Loading