fix: cleared multiple deperecation notices #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerFi
force-pushed
the
fix-deprecation-notices
branch
2 times, most recently
from
63ab349 to
5907480
Compare
Test Results294 tests 294 ✅ 3s ⏱️ Results for commit 0518989. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #821 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 11 11
Lines 1293 1293
=======================================
Hits 1280 1280
Misses 13 13 |
TomerFi
force-pushed
the
fix-deprecation-notices
branch
from
5907480 to
d0fc96c
Compare
pull-request-size
bot
added
size: s
Signed-off-by: Tomer Figenblat <tomer@tomfi.info>
TomerFi
force-pushed
the
fix-deprecation-notices
branch
from
d0fc96c to
0518989
Compare
|
@YogevBokobza would be nice if you can validate the changed method in this PR using a real device |
@thecode, I added related information to the PR's body. I should have done that when I opened the PR. |
thecode
approved these changes
Dec 30, 2024
auto-me-bot
bot
added
status: approved
auto-me-bot
bot
added
status: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I ran some tests, I noticed a couple of deprecation notices:
datetime.datetime.utcnow(), the resolution is specified in the deprecation notice:datetime.datetime.now(datetime.UTC).ssl.SSLContext(), since version 3.10, SSLContext, the default value for the SSLContext function, PROTOCOL_TLS, was deprecated in favour of PROTOCOL_TLS_CLIENT and PROTOCOL_TLS_SERVER.Checklist
Additional information