Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lipschitz constant in FGP_TV for 3D #149

Closed
epapoutsellis opened this issue Jun 11, 2020 · 4 comments · Fixed by #179
Closed

Lipschitz constant in FGP_TV for 3D #149

epapoutsellis opened this issue Jun 11, 2020 · 4 comments · Fixed by #179

Comments

@epapoutsellis
Copy link
Collaborator

epapoutsellis commented Jun 11, 2020

Hi @dkazanc

Why L = 26 here for the 3D case? I think it should be L=sqrt(12).

@dkazanc
Copy link
Collaborator

dkazanc commented Jun 11, 2020

Hi, thanks this could be an error:
is it also sqrt(12) for 2D case here ?

@epapoutsellis
Copy link
Collaborator Author

No, 2D case is np.sqrt(8). I think (haven't check for different bc, it should be true) it should be
sqrt( 2^2 + 2^2 + ... number of dimensions + 2^2)

@dkazanc
Copy link
Collaborator

dkazanc commented Jun 11, 2020

I see, so 2D: multip = (1.0f/(sqrt(8.0)*lambda)) and for 3D: multip = (1.0f/(sqrt(12.0)*lambda)) ?

@epapoutsellis
Copy link
Collaborator Author

Yes but without the square roots

@gfardell gfardell linked a pull request Jul 8, 2020 that will close this issue
paskino added a commit that referenced this issue Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants