-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reader base class and reworked nikon reader to use it #1462
Draft
gfardell
wants to merge
17
commits into
TomographicImaging:master
Choose a base branch
from
gfardell:readerABC
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework ABC + nikon reader methods. Add set_image_roi and set_projections functionality and simplify TIFF reader.
casperdcl
force-pushed
the
master
branch
3 times, most recently
from
September 2, 2024 13:11
a910556
to
f8b513b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a reader base class with new functionality
metadata
andgeometry
as properties of the objectget_raw_flatfield
- returns the flatfields as a numpy ndarray (no processing/casting/cropping)get_raw_darkfield
- returns the darkfields as a numpy ndarray (no processing/casting/cropping)get_raw_data
- returns the data as a numpy ndarray (no processing/casting/cropping)set_panel_roi
- set the ROI in the horizontal and vertical directions, allows cropping and binningset_projections
- set the projections to read in by index as a slice or listget_geometry
- returns a CILAcquisitionGeometry
describing the data respecting ROI and angle selectionread
- returns a CILAcquisitionData
the normalised data respecting ROI and angle selectionMethods marked as abstract that must be defined by a child before the class can be instantiated - Is this what we want?
Updated the
NikonDataReader
to use the base classDescribe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Link relevant issues
closes #1020
closes #1144
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.