Padding and correlation options for WaveletOperator + check for range_geometry size
#1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added string-based `correlation` keywords for defining decomposition `axes`. Specifying `axes` still takes priority though. This is similar behaviour as `GradientOperator` - Added string-based convolution boundary condition `bnd_cond` to set the wavelet extension mode. This is similar behaviour as `GradientOperator` - Removed special case for `VectorGeometry`, the user should give the geometry as with 2D and 3D. There was no reason to have this behaviour.
The size of `range_geometry` is now checked upon initialization to make sure its size matches the wavelet coefficient array size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
bnd_condsimilar toGradientOperator. This just applies the existing options from pywt.axesusing thecorrelationkeyword similar toGradientOperator. This sets theaxesunlessaxesis already specified, which takes priority. It also gives errors and warnings for nonsense choices.range_geometryis now checked upon initialization to make sure the wavelet coefficients fit.VectorGeometrywhich has so many weird behaviours such as not setting the shape automatically. Also the special option for setting 1D domain geometry has been removed because it was pointless.Describe any testing you have performed
Describe any testing you wish to be implemented :)
axesorcorrelation) should keep those dimensions same size as inputcorrelationandaxesare also checked for clashes and overall viabilityChannelsshould not work with data without channelschannelor one of the dimensions in 2D data?Link relevant issues
correlationkeyword due to this comment in Adds WaveletOperator, WaveletNorm #1615bnd_cond, in particular the funny name