-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spdhg with stochastic sampler #1644
Merged
MargaretDuff
merged 144 commits into
TomographicImaging:master
from
MargaretDuff:spdhg_sampler
Nov 25, 2024
Merged
Spdhg with stochastic sampler #1644
MargaretDuff
merged 144 commits into
TomographicImaging:master
from
MargaretDuff:spdhg_sampler
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick docstring Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
…ate prob in spdhg
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
reviewed
Oct 1, 2024
paskino
approved these changes
Oct 15, 2024
gfardell
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly docstring clarification. I think it's very close.
gfardell
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of changes to the unit tests. But I'm happy for you to merge when you're happy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Test with SPDHG https://github.com/TomographicImaging/CIL-Demos/blob/main/misc/testing_sampling_SPDHG.ipynb
Similar results gained for all samplers for SPDHG, with 10 subsets
With 80 subsets:
Link relevant issues
Part of the stochastic work plan. Closes #1575. Closes #1576. Closes #1500. Closes #1496
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.