Wavelet-related tests and corresponding fixes to WaveletOperator and WaveletNorm #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added string-based `correlation` keywords for defining decomposition `axes`. Specifying `axes` still takes priority though. This is similar behaviour as `GradientOperator` - Added string-based convolution boundary condition `bnd_cond` to set the wavelet extension mode. This is similar behaviour as `GradientOperator` - Removed special case for `VectorGeometry`, the user should give the geometry as with 2D and 3D. There was no reason to have this behaviour.
The size of `range_geometry` is now checked upon initialization to make sure its size matches the wavelet coefficient array size.
- Now correctly checks if the wavelet is orthogonal (previously biorthogonal wavelets would be treated wrong) - Now computes the norm for every other wavelet type using power_method
…CIL_with_wavelets into wavelet_regularisation
Starting point for different Wavelet tests. This file will most likely NOT run as is in CIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
WaveletOperatorWaveletNormout=in(see:Soft_Shrinkage(in, tau, out=in)always produces positive values #1662 (comment))test_wavelets.pyDescribe any testing you have performed
bnd_condbnd_cond='periodization'since it gives the most faithful adjointTODO