-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Paganin processor work with one angle #1920
Conversation
a910556
to
f8b513b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this has grown in complexity. I would try to avoid using DataContainer.fill
, and instead look at dealing directly with the array i.e. numpy.copyto
or equivalent. That means this whole block would condense in to one command.
You already have i
and j
defined so you should be able to access the array and copy the relevant portions in directly. You could either calculate the start and end indices of your data block, or reshape the array keeping singleton dimensions in.
If the data isn't in a defined order (maybe that's why you're using fill?) there's a strong argument to reorder it first as writing the memory back to the block will be significantly faster if it's a contiguous block you're writing out.
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments/discussion points. happy for you to address/discuss/over-rule and merge when you're happy.
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Signed-off-by: Hannah Robarts <77114597+hrobarts@users.noreply.github.com>
Changes
Make PaganinProcessor work if there is just one angle in the AcquisitionData
Testing you performed
Related issues/links
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.