Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipp version #1971

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Ipp version #1971

merged 3 commits into from
Oct 29, 2024

Conversation

gfardell
Copy link
Member

Changes

IPP versions need to stay consistent. I've added an ipp_version variable to the recipe to ensure ipp ipp-devel and ipp-include stay consistent, and the the runtime requirements pin the ipp package to that used at build time.

Until a new tag is built with the updated recipe the new install instructions in the recipe should be used.

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc
Checked build instructions work on windows and linux.

Checked build and install locally with conda build.

Related issues/links

fixes #1970

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@paskino paskino merged commit 69391bb into TomographicImaging:master Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError: libippcore.so.10
2 participants