Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAPYB for block data container can take None #2008

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Dec 11, 2024

Changes

Allow SAPYB for the block container to take out=None by creating an out, if needed, the same shape as the container y.
SAPYB for the block container now also always returns

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

Closes #1997

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff self-assigned this Dec 11, 2024
@MargaretDuff MargaretDuff linked an issue Dec 11, 2024 that may be closed by this pull request
@MargaretDuff
Copy link
Member Author

Need to update the docstrings and add to new format

MargaretDuff and others added 3 commits January 9, 2025 15:20
Co-authored-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
@MargaretDuff MargaretDuff merged commit b2f1c62 into master Jan 10, 2025
9 checks passed
@MargaretDuff MargaretDuff deleted the sapyb-for-blockdatacontainer branch January 10, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAPYB for BlockDataContainer
4 participants